Update maven publication to include cksums. #82

mch2 · 2021-11-03T21:17:00Z

Signed-off-by: Marc Handalian [email protected]

Description

This change adds a task to publish to a local staging repo under build/ that includes cksums. It also updates build.sh to use this new task and copy the contents of the staging repo to the output directory.
The maven publish plugin will not include these cksums when publishing to maven local but will when published to a separate folder.

/scripts/build.sh -v 1.2.0 -s true

~/workspace/job-scheduler (maven)$ find artifacts/maven/org/opensearch/opensearch-job-scheduler-spi
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/maven-metadata.xml.sha256
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/maven-metadata.xml
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2-javadoc.jar.sha512
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2-javadoc.jar.md5
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2.pom.md5
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1-sources.jar.sha256
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1.pom.sha512
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2.pom.sha1
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1.jar.sha256
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2-sources.jar.sha1
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1.jar
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/maven-metadata.xml.sha256
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1.pom.sha1
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2.jar.sha256
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2.pom.sha512
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1-sources.jar.md5
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1-javadoc.jar.sha1
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2.jar.md5
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1-sources.jar
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1.pom
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1-javadoc.jar.sha512
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1-javadoc.jar
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2-sources.jar.sha256
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/maven-metadata.xml
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1.pom.sha256
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1.jar.sha512
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2.jar.sha512
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2.pom.sha256
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/maven-metadata.xml.sha512
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1.jar.sha1
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1.jar.md5
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2-javadoc.jar.sha256
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2.pom
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1-sources.jar.sha1
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1-sources.jar.sha512
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2.jar.sha1
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1-javadoc.jar.sha256
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2-javadoc.jar.sha1
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/maven-metadata.xml.md5
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2-sources.jar.sha512
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/maven-metadata.xml.sha1
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1-javadoc.jar.md5
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2-sources.jar
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210704-1.pom.md5
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2-sources.jar.md5
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2.jar
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/1.2.0.0-SNAPSHOT/opensearch-job-scheduler-spi-1.2.0.0-20211103.210801-2-javadoc.jar
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/maven-metadata.xml.sha512
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/maven-metadata.xml.md5
artifacts/maven/org/opensearch/opensearch-job-scheduler-spi/maven-metadata.xml.sha1

Issues Resolved

closes #79

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
[x ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This change adds a task to publish to a local staging repo under build/ that includes cksums. It also updates build.sh to use this new task and copy the contents of the staging repo to the output directory. The maven publish plugin will not include these cksums when publishing to maven local but will when published to a separate folder. Signed-off-by: Marc Handalian <[email protected]>

dblock · 2021-11-04T13:49:45Z

What is the -20211103.210704 appendage? I don't see that in the old output. Is it just because we're building snapshot in the example?

Will you please update https://github.com/opensearch-project/opensearch-plugins/blob/main/BUILDING.md#include-checksums-in-maven-publications as well?

dblock · 2021-11-04T14:22:27Z

Needs to be backported into 1.x/1.2 as well if that's a thing.

mch2 · 2021-11-04T19:12:50Z

What is the -20211103.210704 appendage? I don't see that in the old output. Is it just because we're building snapshot in the example?

Yes this will only appear for snapshot builds. Snapshots that are not published to mavenLocal will include this timestamp. I haven't been able to figure out how to turn this off but I don't think it will be an issue.

Will you please update https://github.com/opensearch-project/opensearch-plugins/blob/main/BUILDING.md#include-checksums-in-maven-publications as well?

ack & looking at backports...

This change adds a task to publish to a local staging repo under build/ that includes cksums. It also updates build.sh to use this new task and copy the contents of the staging repo to the output directory. The maven publish plugin will not include these cksums when publishing to maven local but will when published to a separate folder. Signed-off-by: Marc Handalian <[email protected]>

dblock · 2022-01-11T17:06:49Z

I believe this removed job-scheduler.jar from publishing tp maven, and looking at #114 it may actually be needed.

mch2 · 2022-01-11T20:54:59Z

The base job-scheduler jar was skipped because only SPI was historically published as part of odfe.
I've updated this as part of #117 to be included and configured its pom properly for maven central.

* Support Elasticsearch 7.10 * Fix link for release notes (cherry picked from commit 693cbd4141b0e5f6d3f04449669db5c60657c115)

This change adds a task to publish to a local staging repo under build/ that includes cksums. It also updates build.sh to use this new task and copy the contents of the staging repo to the output directory. The maven publish plugin will not include these cksums when publishing to maven local but will when published to a separate folder. Signed-off-by: Marc Handalian <[email protected]>

mch2 requested a review from dblock November 3, 2021 21:56

peternied approved these changes Nov 3, 2021

View reviewed changes

dblock merged commit c41a184 into opensearch-project:main Nov 4, 2021

mch2 mentioned this pull request Nov 4, 2021

[Backport 1.x] - Update maven publication to include cksums. #83

Merged

5 tasks

mch2 deleted the maven branch November 5, 2021 17:44

dblock mentioned this pull request Jan 11, 2022

Publish job-scheduler JAR to maven, not only -spi #114

Closed

wuychn pushed a commit to ochprince/job-scheduler that referenced this pull request Mar 16, 2023

Support Elasticsearch 7.10 (opensearch-project#82)

d074947

* Support Elasticsearch 7.10 * Fix link for release notes (cherry picked from commit 693cbd4141b0e5f6d3f04449669db5c60657c115)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update maven publication to include cksums. #82

Update maven publication to include cksums. #82

mch2 commented Nov 3, 2021

dblock commented Nov 4, 2021 •

edited

Loading

dblock commented Nov 4, 2021

mch2 commented Nov 4, 2021

dblock commented Jan 11, 2022

mch2 commented Jan 11, 2022

Update maven publication to include cksums. #82

Update maven publication to include cksums. #82

Conversation

mch2 commented Nov 3, 2021

Description

Issues Resolved

Check List

dblock commented Nov 4, 2021 • edited Loading

dblock commented Nov 4, 2021

mch2 commented Nov 4, 2021

dblock commented Jan 11, 2022

mch2 commented Jan 11, 2022

dblock commented Nov 4, 2021 •

edited

Loading